[0.2] Backport #4158 and bump versions to -beta1 #4159
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.2 #4159 +/- ##
==========================================
+ Coverage 88.77% 88.79% +0.02%
==========================================
Files 180 180
Lines 136566 136566
Branches 136566 136566
==========================================
+ Hits 121233 121266 +33
+ Misses 12535 12500 -35
- Partials 2798 2800 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "lightning-types" | |||
| version = "0.3.0+git" | |||
There was a problem hiding this comment.
This commit mostly LGTM; from the commit message, didn't quite catch any methods we removed, but we did modify the clear_ public function signatures in 6836fc4
There was a problem hiding this comment.
Ah, that too. I was referring to this I see in the diff-tree:
-impl<T: sealed::UpfrontShutdownScript> Features<T> {
- /// Unsets the `upfront_shutdown_script` feature
- pub fn clear_upfront_shutdown_script(mut self) -> Self {
- <T as sealed::UpfrontShutdownScript>::clear_bits(&mut self.flags);
- self
- }
-}
-
-impl<T: sealed::ShutdownAnySegwit> Features<T> {
- /// Unsets the `shutdown_anysegwit` feature
- pub fn clear_shutdown_anysegwit(mut self) -> Self {
- <T as sealed::ShutdownAnySegwit>::clear_bits(&mut self.flags);
- self
- }
-}
-
-impl<T: sealed::Wumbo> Features<T> {
- /// Unsets the `wumbo` feature
- pub fn clear_wumbo(mut self) -> Self {
- <T as sealed::Wumbo>::clear_bits(&mut self.flags);
- self
- }
-}
-
-impl<T: sealed::SCIDPrivacy> Features<T> {
- /// Unsets the `scid_privacy` feature
- pub fn clear_scid_privacy(&mut self) {
- <T as sealed::SCIDPrivacy>::clear_bits(&mut self.flags);
- }
-}
-
-impl<T: sealed::AnchorsZeroFeeHtlcTx> Features<T> {
- /// Unsets the `anchors_zero_fee_htlc_tx` feature
- pub fn clear_anchors_zero_fee_htlc_tx(&mut self) {
- <T as sealed::AnchorsZeroFeeHtlcTx>::clear_bits(&mut self.flags);
- }
-}
-
-impl<T: sealed::RouteBlinding> Features<T> {
- /// Unsets the `route_blinding` feature
- pub fn clear_route_blinding(&mut self) {
- <T as sealed::RouteBlinding>::clear_bits(&mut self.flags);
- }
-}
-
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
TheBlueMatt
force-pushed
the
2025-10-0.2-beta
branch
from
010f054 to
3243c0d
Compare
|
Updated to new version of #4158 |
TheBlueMatt
force-pushed
the
2025-10-0.2-beta
branch
from
3243c0d to
214d3ad
Compare
|
Needs rebase, then good to go |
These have been merged, causing our docs.rs builds to fail. Sadly, we saw our docs.rs build fail for the 0.1.6 upload because of this. Backport of 6aea586
Sadly, our docs.rs build failed for 0.1.6 due to the unstable `doc_auto_cfg` feature being removed. Here, we try to emulate docs.rs builds as best we can in CI to head that off in the future. Backport of d3faa03
This bumps `lightning` to 0.2-beta1, `lightning-invoice` to 0.34-beta1, `lightning-types` to 0.3-beta1, and `lightning-dns-resolver` to 0.3-beta1. While `lightning-types` really doesn't entirely merit a version bump here (we almost entirely just added features, which isn't a breaking change), we removed a few redundant feature flag modifying methods, which technically broke semver. Hopefully the next version will be able to avoid that. As a result of the `lightning-types` bump, `lightning-invoice` also gets bumped, though it would otherwise not need it.
TheBlueMatt
force-pushed
the
2025-10-0.2-beta
branch
from
214d3ad to
de3ddfa
Compare
|
Rebased with latest backport of #4158 |
3 participants
No description provided.